Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] helm recreates certs repetededly #845

Closed
tomplus opened this issue Jul 31, 2023 · 2 comments · Fixed by #936
Closed

[operator] helm recreates certs repetededly #845

tomplus opened this issue Jul 31, 2023 · 2 comments · Fixed by #936
Labels
bug Something isn't working chart:operator Issue related to opentelemetry-operator helm chart

Comments

@tomplus
Copy link
Contributor

tomplus commented Jul 31, 2023

Hello Team.

I use the opentelemetry-operator chart as a sub-chart and I've faced the issue where during helm upgrade I get an error:

cannot patch "opentelemetry" with kind OpenTelemetryCollector: 
Internal error occurred: failed calling webhook "mopentelemetrycollector.kb.io": 
failed to call webhook: Post "https://opentelemetry-operator-webhook.test.svc:443/mutate-opentelemetry-io-v1alpha1-opentelemetrycollector?timeout=10s": 
x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "opentelemetry-operator-operator-ca")

It looks like a certificate generated by Helm (certManager.enabled=False) is always replaced and the operator needs some time to reload it, during this time is not possible to update OpenTelemetryCollector's (the webhook has the previous cert). Could the chart use the old Secret if exists or maybe this regeneration is intentional?

I can prepare a PR for it.

Thanks!

@Allex1
Copy link
Contributor

Allex1 commented Oct 23, 2023

Hey @tomplus , sorry , I just saw this issue . Is the offer still available? :)
We did not reproduce it as we're using cert-manager for the most part.

@TylerHelmuth TylerHelmuth added bug Something isn't working chart:operator Issue related to opentelemetry-operator helm chart labels Oct 23, 2023
@tomplus
Copy link
Contributor Author

tomplus commented Oct 25, 2023

Thanks for verifying it. Yeah, the offer is still available :) I'll work on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart:operator Issue related to opentelemetry-operator helm chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants