From 2dd5e9e0c53d41e862859a779a0e0dc5d4ab9ba9 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Mon, 28 Aug 2023 11:39:00 -0700 Subject: [PATCH 1/3] Fix bridge/opencensus NewMetricExporter dep notice --- CHANGELOG.md | 5 +++++ bridge/opencensus/metric.go | 1 + 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7aa5c8051f9..eb6cb538f0d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ## [Unreleased] +### Deprecated + +- The `NewMetricExporter` in `go.opentelemetry.io/otel/bridge/opencensus` was deprecated in `v0.35.0` (#3541). + The deprecation notice format for the function has been corrected to trigger Go documentation and build tooling. (#TBD) + ## [1.17.0/0.40.0/0.0.5] 2023-08-28 ### Added diff --git a/bridge/opencensus/metric.go b/bridge/opencensus/metric.go index 870faa23670..1a623d252a6 100644 --- a/bridge/opencensus/metric.go +++ b/bridge/opencensus/metric.go @@ -70,6 +70,7 @@ type exporter struct { // NewMetricExporter returns an OpenCensus exporter that exports to an // OpenTelemetry (push) exporter. +// // Deprecated: Use NewMetricProducer instead. func NewMetricExporter(base metric.Exporter, res *resource.Resource) metricexport.Exporter { return &exporter{base: base, res: res} From ff3ad7956d81a763127c5c84733488ad4a514efe Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Mon, 28 Aug 2023 11:43:39 -0700 Subject: [PATCH 2/3] Link to NewMetricProducer --- bridge/opencensus/metric.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bridge/opencensus/metric.go b/bridge/opencensus/metric.go index 1a623d252a6..c2e0be49052 100644 --- a/bridge/opencensus/metric.go +++ b/bridge/opencensus/metric.go @@ -71,7 +71,7 @@ type exporter struct { // NewMetricExporter returns an OpenCensus exporter that exports to an // OpenTelemetry (push) exporter. // -// Deprecated: Use NewMetricProducer instead. +// Deprecated: Use [NewMetricProducer] instead. func NewMetricExporter(base metric.Exporter, res *resource.Resource) metricexport.Exporter { return &exporter{base: base, res: res} } From 7eee344a7b1f048ba2f0ddec03b017d14a55b2e9 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Mon, 28 Aug 2023 11:44:00 -0700 Subject: [PATCH 3/3] Add PR number to changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index eb6cb538f0d..038b672e2fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ### Deprecated - The `NewMetricExporter` in `go.opentelemetry.io/otel/bridge/opencensus` was deprecated in `v0.35.0` (#3541). - The deprecation notice format for the function has been corrected to trigger Go documentation and build tooling. (#TBD) + The deprecation notice format for the function has been corrected to trigger Go documentation and build tooling. (#4470) ## [1.17.0/0.40.0/0.0.5] 2023-08-28