Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend plugin/othttp handler to collect metrics as well as traces #542

Closed
evantorrie opened this issue Mar 11, 2020 · 3 comments
Closed
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@evantorrie
Copy link
Contributor

evantorrie commented Mar 11, 2020

The plugin/othttp middleware currently extracts trace ids and context from an incoming HTTP request, creates a new Otel span and augments it with attributes culled from the request and response.

Many systems, including the Opencensus http plugin, also produce corresponding metrics such as

  • server requests
  • server latency
  • bytes read
  • bytes written

tagged with very similar attributes as collected in our Otel http plugin.

As OpenTelemetry combines tracing and metrics, it would seem we should be able to optionally produce similar metrics in an automated fashion using plugin/othttp.

@evantorrie
Copy link
Contributor Author

See some related discussion to this in open-telemetry/opentelemetry-specification#381

@rghetia
Copy link
Contributor

rghetia commented Mar 26, 2020

It would be good to have standard metrics defined for http for plugins in the spec.

@MrAlias MrAlias added the good first issue Good for newcomers label Jun 11, 2020
@AndrewGrachov
Copy link
Contributor

AndrewGrachov commented Jun 20, 2020

Hi, we are adapting the opentelemetry now(our stack is both Golang and Nodejs), we did such functionality by ourserlves, but better it will be standard solution.
would like to contribute and take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants