Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createScopeInfoMetric is unnecessarily called when it returns an error #4091

Closed
pellared opened this issue May 15, 2023 · 0 comments · Fixed by #4499
Closed

createScopeInfoMetric is unnecessarily called when it returns an error #4091

pellared opened this issue May 15, 2023 · 0 comments · Fixed by #4499
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Milestone
untracked

Comments

@pellared
Copy link
Member

If non-nil error is returned by createScopeInfoMetric then it will be called during each Collect for given scope.

Originally posted by @pellared in #3899 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Call scopeInfoMetrics only once even if it returns an error
2 participants
@pellared @XSAM