Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExplicitBucketBoundaries hint API #4003

Closed
MrAlias opened this issue Apr 14, 2023 · 3 comments
Closed

Add ExplicitBucketBoundaries hint API #4003

MrAlias opened this issue Apr 14, 2023 · 3 comments
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:API Related to an API package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 14, 2023

Problem Statement

The specification has added an advice API. The Go API doesn't currently support this feature.

Proposed Solution

Add support for this feature.

Prior Art

Java implementation.
@MrAlias MrAlias added enhancement New feature or request pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics blocked:design Waiting on design work to be completed before implementation can start. labels Apr 14, 2023
@MrAlias MrAlias mentioned this issue Jun 1, 2023
Closed
@liufuyang
Copy link

Hey there, thanks for note down the issue here, any progress on this? Looks like it is called advisory parameters now?

And it would be nice if this stable ExplicitBucketBoundaries can be added soon and also having an example showing how to use it :)

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advisory-parameter-explicitbucketboundaries

@pellared
Copy link
Member

pellared commented Nov 2, 2023

@dashpole, is it not solved via #4603 and #4605?

@dashpole
Copy link
Contributor

dashpole commented Nov 2, 2023

Yes

@dashpole dashpole closed this as completed Nov 2, 2023
@dashpole dashpole removed the blocked:design Waiting on design work to be completed before implementation can start. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:API Related to an API package
Projects
Go: Metric API (Post-GA)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liufuyang @dashpole @pellared @MrAlias