Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore moving readFile to host_id_bsd.go #3972

Closed
MrAlias opened this issue Apr 6, 2023 · 1 comment · Fixed by #4015
Closed

Explore moving readFile to host_id_bsd.go #3972

MrAlias opened this issue Apr 6, 2023 · 1 comment · Fixed by #4015
Assignees
Labels
area:resources Part of OpenTelemetry resources good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 6, 2023

Currently it is ignored as unused by the linter because it will fail on systems that do not built the resource detector that uses it.

The possibility of moving it should be explored.

Originally posted by @pellared in #3956 (comment)

@MrAlias MrAlias added help wanted Extra attention is needed good first issue Good for newcomers area:resources Part of OpenTelemetry resources labels Apr 6, 2023
@unicod3
Copy link
Contributor

unicod3 commented Apr 8, 2023

Hey @MrAlias,

I've started looking into this, since linter complained about it I thought there might be a way to tell golangci-lint that it is used in other platforms but it seems there is no way to tell this as of now, see: dominikh/go-tools#938

It seems host_id_linux also calls it. I'll check how we can move into the platform files.

https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/resource/host_id_linux.go#L21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:resources Part of OpenTelemetry resources good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
2 participants