Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix histogram instrument unit test #2442

Closed
hanyuancheung opened this issue Dec 10, 2021 · 0 comments · Fixed by #2716
Closed

Fix histogram instrument unit test #2442

hanyuancheung opened this issue Dec 10, 2021 · 0 comments · Fixed by #2716
Assignees
@XSAM
Labels
bug Something isn't working
Milestone
Release v1.7.0

Comments

@hanyuancheung
Copy link
Member

Description

Following discussion: #2423 (comment)

The exporter should still be able to test these histogram instrument kinds, after having removed MinMaxSumCount kind aggregation. But when keeping histogram instrument test, there's something went wrong, so we should fix the test case.

Steps To Reproduce

Run make test with keeping 'test-int64-histogram' and 'test-float64-histogram'.

Expected behavior

Exporter still be able to test histogram instrument kinds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XSAM XSAM

Labels
bug Something isn't working
Projects
Go: Bugs
Archived in project
Milestone
Release v1.7.0
Development

Successfully merging a pull request may close this issue.

Fix histogram e2e test XSAM/opentelemetry-go
3 participants
@MrAlias @XSAM @hanyuancheung