Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or remove resource.WithBuiltinDetectors() #2026

Closed
jmacd opened this issue Jun 21, 2021 · 3 comments · Fixed by #2097
Closed

Update or remove resource.WithBuiltinDetectors() #2026

jmacd opened this issue Jun 21, 2021 · 3 comments · Fixed by #2097
Assignees
Labels
area:resources Part of OpenTelemetry resources enhancement New feature or request

Comments

@jmacd
Copy link
Contributor

jmacd commented Jun 21, 2021

Problem Statement

I noticed that the resource.WithBuiltinDetectors() option, which once included all the builtin detectors, has not been maintained. It could be removed, or it could be updated to actually name all the builtin detectors, which includes WithHost(),WithOSType(), and WithProcess() options which are not included in resource.Default().

Proposed Solution

Remove WithBuiltinDetectors().

Alternatives

Add WithHost(),WithOSType(), and WithProcess() to the result from WithBuiltinDetectors().

@jmacd jmacd added the enhancement New feature or request label Jun 21, 2021
@jmacd
Copy link
Contributor Author

jmacd commented Jun 21, 2021

Note: #1840 adds more builtin detectors.

@MrAlias MrAlias added the area:resources Part of OpenTelemetry resources label Jun 25, 2021
@hanyuancheung
Copy link
Member

My honor to take this issue, I'll do it as above said, add WithHost(), WithOSType(), WithProcess() instead of resource.WithBuiltinDetectors(). Could you please assign it to me?

@nelsonghezzi
Copy link
Contributor

#1840 was merged, so now WithOSDescription() can be added as well (or just add WithOS() which includes both OS type and description detectors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:resources Part of OpenTelemetry resources enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants