Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add TraceState to SpanContext #1302

Closed
gavinservai opened this issue Nov 2, 2020 · 1 comment · Fixed by #1340
Closed

API: Add TraceState to SpanContext #1302

gavinservai opened this issue Nov 2, 2020 · 1 comment · Fixed by #1340
Assignees
@matej-g
Labels
area:trace Part of OpenTelemetry tracing help wanted Extra attention is needed pkg:API Related to an API package
Milestone
RC1

Comments

@gavinservai
Copy link

The spec mentions TraceState under SpanContext:
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#spancontext

The previous issue that was filed for this was closed, mentioning that tracestate is not a part of the spec anymore.
I'm not sure why this was done, as an open PR from the spec was linked - and that PR did not end up getting merged into the actual spec

#74
@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing pkg:API Related to an API package priority:p1 labels Nov 3, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 3, 2020
@MrAlias MrAlias added the help wanted Extra attention is needed label Nov 5, 2020
@matej-g
Copy link
Contributor

matej-g commented Nov 6, 2020

Yes, looks like that issue was prematurely closed together with the original PR, while recently TraceState has been moved to API and operations on it have been specified.

@MrAlias if you agree I would like to take this one.

@matej-g matej-g mentioned this issue Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matej-g matej-g

Labels
area:trace Part of OpenTelemetry tracing help wanted Extra attention is needed pkg:API Related to an API package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Add TraceState to SpanContext in API matej-g/opentelemetry-go
3 participants
@MrAlias @gavinservai @matej-g