Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the context keys #1182

Closed
rakyll opened this issue Sep 17, 2020 · 3 comments · Fixed by #1731
Closed

Reconsider the context keys #1182

rakyll opened this issue Sep 17, 2020 · 3 comments · Fixed by #1731
Assignees
Labels
pkg:API Related to an API package
Milestone

Comments

@rakyll
Copy link
Contributor

rakyll commented Sep 17, 2020

Based on the conversations at open-telemetry/opentelemetry-specification#948, we may need to reconsider the entries we propagate in the context and whether we will allow two different context keys. I'm filing this issue for visibility because it might be API breaking.

@MrAlias MrAlias added blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made pkg:API Related to an API package priority:p1 labels Sep 22, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 22, 2020
@punya
Copy link
Member

punya commented Feb 17, 2021

Does this issue relate to #1069?

@MrAlias
Copy link
Contributor

MrAlias commented Feb 18, 2021

@rakyll can you add a bit more context here. We want to make progress on this for the RC release and want to know if these relate to the remote/local span context keys or some other keys.

@MrAlias MrAlias self-assigned this Feb 18, 2021
@rakyll
Copy link
Contributor Author

rakyll commented Feb 22, 2021

The link to the spec issue was incorrect, see open-telemetry/opentelemetry-specification#949 for the earlier discussion.

@MrAlias MrAlias removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:API Related to an API package
Projects
None yet
3 participants