Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate restructuring the BatchSpanProcessor queue and batching algorithm #1178

Open
MrAlias opened this issue Sep 15, 2020 · 3 comments
Labels
area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 15, 2020

As a result of our queueing strategy with the enque being asynchronous from the processing of the batch it is possible for spans to be dropped instead of flushed when a user calls for this flush or shutdown.

Alternatives should be discussed here.

Originally posted by @MrAlias in #1166 (comment)

@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:SDK Related to an SDK package release:after-ga labels Sep 15, 2020
@MadVikingGod
Copy link
Contributor

I experimented with a batcher that uses a channel to manage state a while back here. If this looks like a promising route I can put a bit more time to double check that it works 100%, and add more comments to aid in getting this ready for a PR.

@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 19, 2021

I experimented with a batcher that uses a channel to manage state a while back here. If this looks like a promising route I can put a bit more time to double check that it works 100%, and add more comments to aid in getting this ready for a PR.

Sounds good to me 👍.

@pellared
Copy link
Member

pellared commented Jul 24, 2023

Related issues:

Side note: The processing logic may be implemented similarly to PeriodicReader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:SDK Related to an SDK package
Projects
None yet
Development

No branches or pull requests

3 participants