Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review LogSize configuration #136

Closed
MikeGoldsmith opened this issue May 3, 2023 · 2 comments
Closed

Review LogSize configuration #136

MikeGoldsmith opened this issue May 3, 2023 · 2 comments

Comments

@MikeGoldsmith
Copy link
Member

Review hardcoded logsize and whether we should allow users to adjust via configuration.

Originally posted by @MikeGoldsmith in #128 (review)

@edeNFed
Copy link
Contributor

edeNFed commented May 3, 2023

Copying my comment from the original thread:

The default size is 1024 bytes, which may not be enough for all eBPF programs.
This sets the size of the requested buffer allocated from the kernel when loading eBPF programs. Allowing users to control it may have some security concerns (for example, setting a really high value causing huge memory allocation)

@MrAlias
Copy link
Contributor

MrAlias commented Nov 21, 2024

Verifier log size was removed in #965. Upstream removed the need to configure this: https://github.com/cilium/ebpf/releases.

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants