Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelhttptrace: allow tracing by adding events #876

Closed
tonistiigi opened this issue Jul 10, 2021 · 0 comments · Fixed by #879
Closed

otelhttptrace: allow tracing by adding events #876

tonistiigi opened this issue Jul 10, 2021 · 0 comments · Fixed by #879
Milestone

Comments

@tonistiigi
Copy link
Contributor

tonistiigi commented Jul 10, 2021

In OpenTracing the equivalent httptrace implementation worked by adding logs(events in opentelemetry) to the parent span https://github.com/opentracing-contrib/go-stdlib/blob/00fa856341a83c0ee331ef758856ad41fdabbea7/nethttp/client.go#L286-L292 while otelhttptrace creates new spans.

In an app that creates a lot of traces, this creates a lot of noise and in my case, I would prefer the timestamped logs. Assuming some users prefer spans, can we make this configurable. For example, variadic Option field to NewClientTrace.

@tonistiigi tonistiigi changed the title otelhttptrace: allow tracing by adding logs otelhttptrace: allow tracing by adding events Jul 11, 2021
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants