Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop setting HTTP status text #357

Closed
MrAlias opened this issue Sep 22, 2020 · 3 comments
Closed

Stop setting HTTP status text #357

MrAlias opened this issue Sep 22, 2020 · 3 comments
Labels
area: instrumentation Related to an instrumentation package good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 22, 2020

In the HTTP instrumentation we need to not set the status text (they are inferable from the status code). This is to conform to open-telemetry/opentelemetry-specification#972

@MrAlias MrAlias added good first issue Good for newcomers help wanted Extra attention is needed area: instrumentation Related to an instrumentation package release:required-for-ga labels Sep 22, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 22, 2020
@matej-g
Copy link
Contributor

matej-g commented Oct 5, 2020

I had a look and it seems after open-telemetry/opentelemetry-go#1194 no further action is necessary in the contrib repository. The method HTTPAttributesFromHTTPStatusCode from go.opentelemetry.io/otel/semconv used within HTTP instrumentation packages no longer includes status text attribute.

Is this correct?

@Aneurysm9
Copy link
Member

I had a look and it seems after open-telemetry/opentelemetry-go#1194 no further action is necessary in the contrib repository. The method HTTPAttributesFromHTTPStatusCode from go.opentelemetry.io/otel/semconv used within HTTP instrumentation packages no longer includes status text attribute.

Is this correct?

That sounds correct. I believe the otelhttp instrumentation delegated to the semconv package for the most part, so resolving the issue there should extend to otelhttp as well.

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 13, 2020

Resolved by open-telemetry/opentelemetry-go#1194 and subsequent updates here.

@MrAlias MrAlias closed this as completed Oct 13, 2020
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants