Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for transport layer in instrumentation net/http #3134

Closed
kw510 opened this issue Jan 5, 2023 · 4 comments · Fixed by #4707 · May be fixed by #3769
Closed

Add metrics for transport layer in instrumentation net/http #3134

kw510 opened this issue Jan 5, 2023 · 4 comments · Fixed by #4707 · May be fixed by #3769

Comments

@kw510
Copy link

kw510 commented Jan 5, 2023

Metrics are provided in the handler of net/http, however they are not provided in the transport layer. This would be super useful to monitor outgoing requests.

https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/net/http/otelhttp/transport.go

@rangzen
Copy link

rangzen commented May 4, 2023

I invite you to follow #3765 to avoid duplicating the actual problem when resolving this issue.

@Sovietaced
Copy link
Contributor

Sovietaced commented Sep 25, 2023

@MrAlias Is this an issue you would be open to having a community contribution for? I find it strange that client side metrics are not present for HTTP/gRPC. Server side metrics are only useful if the client can reach the server.

@jlordiales
Copy link

@Sovietaced there's already an open PR for this: #3769

@Sovietaced
Copy link
Contributor

Sovietaced commented Sep 25, 2023

Thanks @jlordiales

I will focus my efforts there.

@MrAlias MrAlias added this to the v0.48.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants