Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing invocations for BaseProcessor<LogRecord>.OnStart #5835

Closed
wants to merge 2 commits into from
Closed

Add missing invocations for BaseProcessor<LogRecord>.OnStart #5835

wants to merge 2 commits into from

Conversation

konjac
Copy link

@konjac konjac commented Sep 14, 2024 •
edited
Loading

Fixes #5834

Changes

Add BaseProcessor.OnStart to be paired with BaseProcessor.OnEnd.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@konjac konjac requested a review from a team September 14, 2024 09:25
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 14, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Sep 14, 2024
@konjac konjac mentioned this pull request Sep 14, 2024
Closed
@konjac konjac changed the title Add BaseProcessor<LogRecord>.OnStart Add missing invocations for BaseProcessor<LogRecord>.OnStart Sep 14, 2024
cijothomas
cijothomas requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs by design only have OnEnd.
Start/End both are available for Spans which has the notion of start of span and end of span, but Log is a point in time thing.

@reyang reyang closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas requested changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Log processor' OnStart is never invoked.
3 participants
@konjac @cijothomas @reyang