Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network.protocol.version - Should it be request.version or response.version? #4928

Closed
vishweshbankwar opened this issue Oct 6, 2023 · 0 comments · Fixed by #5043
Closed

network.protocol.version - Should it be request.version or response.version? #4928

vishweshbankwar opened this issue Oct 6, 2023 · 0 comments · Fixed by #5043
Labels
bug Something isn't working
Milestone
Instrumentation-1...

Comments

@vishweshbankwar
Copy link
Member

Currently, we use request.version property to set network.protocol.version. However, with recent ootb metrics addition I noticed runtime is using response.version to set network.protocol.version tag https://github.com/dotnet/runtime/blob/7204fbe5f56d52dd3fc4238e33de45f532f05d50/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs#L113. Opening this issue to clarify the correct value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Instrumentation-1.0.0
1 participant
@vishweshbankwar