Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OTEL_SDK_DISABLED #4155

Open
Kielek opened this issue Feb 7, 2023 · 2 comments
Open

Support for OTEL_SDK_DISABLED #4155

Kielek opened this issue Feb 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Kielek
Copy link
Contributor

Kielek commented Feb 7, 2023

Feature Request

Support for OTEL_SDK_DISABLED based on https://github.com/open-telemetry/opentelemetry-specification/blob/dd47c009da1de335c540decc5d5930e46ea61916/specification/sdk-environment-variables.md?plain=1#L71

Previous PR: #3639

Additional Context

Found while working on open-telemetry/opentelemetry-dotnet-instrumentation#2009

@Kielek Kielek added the enhancement New feature or request label Feb 7, 2023
@oppegard
Copy link
Member

oppegard commented Feb 9, 2023

See also #1453, which I found by checking if the .NET SDK supported OTEL_TRACES_EXPORTER.

@julealgon
Copy link

We need this setting... we encountered a heavy load situation where we need to conditionally instrument a given process due to resource constraints on a machine.

I almost went ahead and tried to use it but decided to check in the repo first and found out it was not being honored.

We'll probably have to create a custom version of the AddOpenTelemetry method that respects this flag now on our side. And hopefully later we can just replace the implementation/update the package without having to reconfigure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants