-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set a maximum attribute length #3297
Comments
@ejsmith I'll be working on a solution to this soon. I started some work in #3231 experimenting with doing truncation in the shim API. I also proposed it in the .NET activity API (dotnet/runtime#68528), but at this time there's a desire to solve this in the SDK. Specifically in exporters per this comment #3231 (comment). I've been wrapping up some work to handle attributes uniformly across all exporters and intend to circle back and address these length limits. |
Sorry to highjack this. I would need this functionality, but I'm still targeting .net 6 and it seems like this is only included in 1.4.1-beta that ultimately references system.diagnostics 7.0 preview. Is there any chance this will get included in a stable package of the exporter, like 1.3.2 or similar? Thanks! |
@AlexandruRus23 This functionality will be released with 1.4.0 and can be used now by .NET 6 applications using the beta release. System.Diagnostics.DiagnosticSource version 7 supports .NET 6. See: https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/7.0.0-rc.2.22472.3 |
@alanwest Am I correct that it is working only for OTLP exporter and it is not documented? |
I created #3949 |
@pellared The attribute limit configuration is supported by all the exporters provided by this repo: OTLP (traces and logs), Jaeger, and Zipkin. Metric and resource attributes are not subject to the limits per the spec. edit:
Lies... you're correct, only the OTLP exporter is supported currently. |
Feature Request
NewRelic limits their attribute length to 4096 characters and if an attribute is larger than that, it will drop the data. It would be nice to have an option in the client that truncates any attribute values that are longer than a given size.
The text was updated successfully, but these errors were encountered: