-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram aggregation should support Min Max #2560
Comments
I'm interested in helping with this item with some guidance 🙂 |
Sure. I wanted to wait till open-telemetry/opentelemetry-proto#279 is merged. But we don't have to wait really for that. |
Removing this from 1.3.0 milestone and moving to 1.4.0. |
Hi, the previous PR seems to be closed due to inactivity. |
Yes, I plan to work on it this week, sorry I missed this notification. It should be a fairly simple fingers crossed rebase and touch up to the existing PR :) |
Are there any docs on how to make this work with the PrometheusExporter? I can't figure out if there is anything special to do here or the exporter. The |
MinMax is not supported for PrometheusExporter. The spec does not mention how to convert Min/Max for Prometheus. |
Thanks for clarification @cijothomas. Do you have any advice on how to proceed? I'm used to using Histogram data type for gauge type metrics like "latency" or "delay" where max data is important. The data itself is a gauge, but missing all the data in between the sampling points is undesirable. It looks like with OpenTelemetry there's no datatype that would give me this data Edit: To reference a statsd analog that I've used before: https://github.com/statsd/statsd/blob/master/docs/metric_types.md#timing This is perhaps not well named, as this type is useful for any "gauge-like" metric, where you are interested in all data, and not just the last at time of sampling. |
I don't fully understand the issue you are facing. If the issue is Prometheus Exporter missing min/max, then this is just a matter of OTel spec clarifying how to map Min/Max to Prometheus model (likely a Prometheus Gauge). Please open an issue in the spec repo for this. If it is something else, could you elaborate/clarify the exact ask? |
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation
It should be collected by default, with the ability to turn off.
The text was updated successfully, but these errors were encountered: