-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema URL support #2417
Comments
related spec PR: open-telemetry/opentelemetry-specification#2180 |
Once the semantic conventions becomes stable, the instrumentation libraries can go stable. But they'll need schema_url support to point to the version of the semantic conventions its implementing. |
Seems like a potential dupe of #4316 - If we added a dictionary to Meter and ActivitySource you can use a well-known key name for the URL. There is an existing precedent in the Resource API which is a dictionary and semantic conventions for the key names. |
How are you planning to stabilize any instrumentation library or resource detector without this feature? If the telemetry producers do not set the schema URL then they fall into "Fixed Schema Telemetry Producers" and therefore:
Source: https://opentelemetry.io/docs/specs/otel/telemetry-stability/ This feature is required by the specification for a very long time.
@open-telemetry/dotnet-maintainers Related comment: dotnet/runtime#63651 (comment) |
Not really a duplicate issue. This is still a separate issue, but it is possible to use a well known key in the Meter level tags and store schema_url there, and provide extension method (In OTel) like meter.GetSchemaUrl() which retrieves it from the well known key. I don't think such a thing was done in Resource, but we have done it for Activity.Status. |
This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day. |
Spec requires Meter, Tracer(ActivitySource) to have a 3rd parameter schemaUrl.
https://github.com/open-telemetry/opentelemetry-specification/pull/1666/files
As both these classes are part of .NET Runtime, we need to request this change in .NET Runtime repo. Opening an issue here first to see if there is any alternatives in the meantime, and to track this (for consideration in next .NET release)
The text was updated successfully, but these errors were encountered: