From e0913f9add070ed6ae72fd14ce00a18ae028dc78 Mon Sep 17 00:00:00 2001 From: Pierre Tessier Date: Tue, 19 Sep 2023 23:00:52 -0400 Subject: [PATCH 1/2] metrics filter and transform Signed-off-by: Pierre Tessier --- src/otelcollector/otelcol-config.yml | 31 ++++++++++++++++++---------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/src/otelcollector/otelcol-config.yml b/src/otelcollector/otelcol-config.yml index e96f0ec871..4352bf0eff 100644 --- a/src/otelcollector/otelcol-config.yml +++ b/src/otelcollector/otelcol-config.yml @@ -17,16 +17,25 @@ exporters: processors: batch: - transform: - metric_statements: - - context: metric - statements: - # FIXME: remove this when this is issue is resolved: https://github.com/open-telemetry/opentelemetry-java/issues/4834 - - set(description, "") where name == "queueSize" - # FIXME: remove this when the following 2 issues are resolved - # Java: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/9478 - # Go: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4301 - - set(description, "") where name == "rpc.server.duration" + filter/ottl: + error_mode: ignore + metrics: + metric: + # FIXME: remove when a Metrics View is implemented in the checkout and productcatalog components + # or when this issue is resolved: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/3071 + - 'name == "rpc.server.duration"' + transform: + metric_statements: + - context: metric + statements: + # FIXME: remove when this issue is resolved: https://github.com/open-telemetry/opentelemetry-java/issues/4834 + - set(description, "") where name == "queueSize" + # FIXME: remove when these 2 issues are resolved: + # Java: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/9478 + # Go: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4301 + - set(description, "") where name == "rpc.server.duration" + # FIXME: remove when this issue is resolved: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/1958 + - set(description, "") where name == "http.client.duration" connectors: spanmetrics: @@ -39,7 +48,7 @@ service: exporters: [logging, spanmetrics] metrics: receivers: [otlp, spanmetrics] - processors: [transform, batch] + processors: [filter/ottl, transform, batch] exporters: [logging] logs: receivers: [otlp] From 086d57924d0c2aa96785d00ba84ac5357123290d Mon Sep 17 00:00:00 2001 From: Pierre Tessier Date: Wed, 27 Sep 2023 15:04:18 -0400 Subject: [PATCH 2/2] remove filtered metric Signed-off-by: Pierre Tessier --- src/otelcollector/otelcol-config.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/otelcollector/otelcol-config.yml b/src/otelcollector/otelcol-config.yml index 4352bf0eff..db0657bed3 100644 --- a/src/otelcollector/otelcol-config.yml +++ b/src/otelcollector/otelcol-config.yml @@ -30,10 +30,6 @@ processors: statements: # FIXME: remove when this issue is resolved: https://github.com/open-telemetry/opentelemetry-java/issues/4834 - set(description, "") where name == "queueSize" - # FIXME: remove when these 2 issues are resolved: - # Java: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/9478 - # Go: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4301 - - set(description, "") where name == "rpc.server.duration" # FIXME: remove when this issue is resolved: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/1958 - set(description, "") where name == "http.client.duration"