From b0114a02f6c64153b863c51e657ce1f23dcf4019 Mon Sep 17 00:00:00 2001 From: Lalit Date: Wed, 24 May 2023 14:53:20 -0700 Subject: [PATCH 1/2] update histogram --- api/include/opentelemetry/metrics/sync_instruments.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/include/opentelemetry/metrics/sync_instruments.h b/api/include/opentelemetry/metrics/sync_instruments.h index b81a412680..ed7367e40e 100644 --- a/api/include/opentelemetry/metrics/sync_instruments.h +++ b/api/include/opentelemetry/metrics/sync_instruments.h @@ -97,14 +97,14 @@ class Histogram : public SynchronousInstrument /** * Records a value. * - * @param value The increment amount. May be positive, negative or zero. + * @param value The increment amount. MUST be non-negative. */ virtual void Record(T value, const context::Context &context) noexcept = 0; /** * Records a value with a set of attributes. * - * @param value The increment amount. May be positive, negative or zero. + * @param value The increment amount. MUST be non-negative. * @param attributes A set of attributes to associate with the count. */ virtual void Record(T value, From 51eeaf2c637b09e7cd45aca385761d9b0b3d7eb8 Mon Sep 17 00:00:00 2001 From: Lalit Kumar Bhasin Date: Thu, 25 May 2023 00:10:36 -0700 Subject: [PATCH 2/2] fix comment --- api/include/opentelemetry/metrics/sync_instruments.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/include/opentelemetry/metrics/sync_instruments.h b/api/include/opentelemetry/metrics/sync_instruments.h index ed7367e40e..b26e527c2c 100644 --- a/api/include/opentelemetry/metrics/sync_instruments.h +++ b/api/include/opentelemetry/metrics/sync_instruments.h @@ -97,14 +97,14 @@ class Histogram : public SynchronousInstrument /** * Records a value. * - * @param value The increment amount. MUST be non-negative. + * @param value The measurement value. MUST be non-negative. */ virtual void Record(T value, const context::Context &context) noexcept = 0; /** * Records a value with a set of attributes. * - * @param value The increment amount. MUST be non-negative. + * @param value The measurement value. MUST be non-negative. * @param attributes A set of attributes to associate with the count. */ virtual void Record(T value,