From 75f7a26fc6a91a9a31eca505612f7184a24b88aa Mon Sep 17 00:00:00 2001 From: owentou Date: Sat, 23 Oct 2021 22:20:14 +0800 Subject: [PATCH 1/2] Fix #1028 Signed-off-by: owentou --- .../opentelemetry/sdk/metrics/sync_instruments.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sdk/include/opentelemetry/sdk/metrics/sync_instruments.h b/sdk/include/opentelemetry/sdk/metrics/sync_instruments.h index e97c09aa5e..0c1bd1a245 100644 --- a/sdk/include/opentelemetry/sdk/metrics/sync_instruments.h +++ b/sdk/include/opentelemetry/sdk/metrics/sync_instruments.h @@ -189,12 +189,12 @@ class BoundUpDownCounter final : public BoundSynchronousInstrument, { public: - BoundUpDownCounter() = default; + BoundUpDownCounter() = default; - BoundUpDownCounter(nostd::string_view name, - nostd::string_view description, - nostd::string_view unit, - bool enabled) + BoundUpDownCounter(nostd::string_view name, + nostd::string_view description, + nostd::string_view unit, + bool enabled) : BoundSynchronousInstrument(name, description, unit, From 75ed1cd19d768c869c6b8b4df1e1093140b6d48c Mon Sep 17 00:00:00 2001 From: owent Date: Sun, 24 Oct 2021 10:43:26 +0800 Subject: [PATCH 2/2] Fix constructor of `GaugeAggregator` Signed-off-by: owent --- .../opentelemetry/sdk/metrics/aggregator/gauge_aggregator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/include/opentelemetry/sdk/metrics/aggregator/gauge_aggregator.h b/sdk/include/opentelemetry/sdk/metrics/aggregator/gauge_aggregator.h index c74d057bd1..e953e8c619 100644 --- a/sdk/include/opentelemetry/sdk/metrics/aggregator/gauge_aggregator.h +++ b/sdk/include/opentelemetry/sdk/metrics/aggregator/gauge_aggregator.h @@ -33,7 +33,7 @@ template class GaugeAggregator : public Aggregator { public: - explicit GaugeAggregator(metrics_api::InstrumentKind kind) + explicit GaugeAggregator(metrics_api::InstrumentKind kind) { static_assert(std::is_arithmetic::value, "Not an arithmetic type"); this->kind_ = kind;