Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper handling of Span Links in ETW exporter #649

Closed
maxgolov opened this issue Apr 5, 2021 · 3 comments
Closed

Proper handling of Span Links in ETW exporter #649

maxgolov opened this issue Apr 5, 2021 · 3 comments
Assignees
@maxgolov
Labels
area:exporter priority:p2 Issues that are not blocking Stale

Comments

@maxgolov
Copy link
Contributor

maxgolov commented Apr 5, 2021

There is one missing API path, where ETW exporter is not accepting Span Links properly.

This issue is reported to address the concern found during code review.

#519 (comment)

It is of lower priority since only specific path is affected, the core functionality is operational.
@maxgolov maxgolov changed the title Proper handling of Links in ETW exporter Proper handling of Span Links in ETW exporter Apr 5, 2021
@maxgolov maxgolov self-assigned this Apr 5, 2021
@maxgolov maxgolov mentioned this issue Apr 5, 2021
Merged
@maxgolov maxgolov added the priority:p2 Issues that are not blocking label Apr 5, 2021
@maxgolov maxgolov mentioned this issue May 6, 2021
Merged
@maxgolov
Copy link
Contributor Author

maxgolov commented May 6, 2021

Also need to address the other couple minor feedbacks from #702

@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 15, 2021
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxgolov maxgolov

Labels
area:exporter priority:p2 Issues that are not blocking Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxgolov