Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to abseil::variant as default variant class across api #572

Closed
lalitb opened this issue Feb 10, 2021 · 0 comments · Fixed by #771
Closed

Switch to abseil::variant as default variant class across api #572

lalitb opened this issue Feb 10, 2021 · 0 comments · Fixed by #771
Assignees

Comments

@lalitb
Copy link
Member

lalitb commented Feb 10, 2021

opentelemetry-cpp api currenty brings 3 variants of variant class switchable at build time.

  1. std variant ( HAVE_CPP_STDLIB switch : https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/std/variant.h

  2. abseil variant ( HAVE_ABSEIL_VARIANT switch: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry//nostd/absl/types/variant.h )

  3. mark variant ( enabled by default: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/nostd/mpark/variant.h )

Going forward - it would be better to converge to single variant class ( possibly abseil::variant as it is usable with vc2015 ), and get rid of rest of the libraries.

Refer to discussions in this PR thread: #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants