Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXEMPLAR] Update ExemplarFilter and ExemplarReservoir for spec #2372

Merged
merged 73 commits into from
Apr 29, 2024

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Oct 16, 2023

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.35%. Comparing base (497eaf4) to head (a9c4e76).
Report is 56 commits behind head on main.

❗ Current head a9c4e76 differs from pull request most recent head 8231e1e. Consider uploading reports for the commit 8231e1e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
+ Coverage   87.12%   87.35%   +0.24%     
==========================================
  Files         200      199       -1     
  Lines        6109     6023      -86     
==========================================
- Hits         5322     5261      -61     
+ Misses        787      762      -25     
Files Coverage Δ
sdk/src/metrics/meter_provider.cc 82.50% <0.00%> (-4.34%) ⬇️
sdk/src/metrics/meter_context.cc 73.69% <0.00%> (-3.02%) ⬇️

... and 36 files with indirect coverage changes

@github-actions github-actions bot added Stale and removed Stale labels Dec 17, 2023
@marcalff
Copy link
Member

marcalff commented Feb 7, 2024

@ThomsonTan ThomsonTan marked this pull request as ready for review March 28, 2024 06:37
@ThomsonTan ThomsonTan requested a review from a team March 28, 2024 06:37
@ThomsonTan ThomsonTan added the pr:please-review This PR is ready for review label Mar 28, 2024
@marcalff marcalff assigned marcalff and esigo and unassigned marcalff Apr 3, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I fixed some typo in the PR number in CHANGELOG

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lalitb lalitb self-assigned this Apr 22, 2024
@ThomsonTan
Copy link
Contributor Author

Talked with Lalit. He is fine to merge this PR and address potential feedback in future PRs.

I am going to merge it for now.

@ThomsonTan ThomsonTan merged commit 2d077f8 into open-telemetry:main Apr 29, 2024
48 checks passed
@ThomsonTan ThomsonTan deleted the SetExemplarInSDK branch April 29, 2024 20:14
@marcalff marcalff changed the title Update ExemplarFilter and ExemplarReservoir for spec [EXAMPLAR] Update ExemplarFilter and ExemplarReservoir for spec Jun 20, 2024
@marcalff marcalff changed the title [EXAMPLAR] Update ExemplarFilter and ExemplarReservoir for spec [EXEMPLAR] Update ExemplarFilter and ExemplarReservoir for spec Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants