Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPENTELEMETRY_INSTALL_default should be ON when oetl-cpp is on top level. #2061

Closed
owent opened this issue Mar 16, 2023 · 0 comments · Fixed by #2062
Closed

OPENTELEMETRY_INSTALL_default should be ON when oetl-cpp is on top level. #2061

owent opened this issue Mar 16, 2023 · 0 comments · Fixed by #2062
Labels
bug Something isn't working

Comments

@owent
Copy link
Member

owent commented Mar 16, 2023

We should still install otel-cpp by default when otel-cpp is on the top level. Just like gRPC_INSTALL_default.
@owent owent added the bug Something isn't working label Mar 16, 2023
@owent owent mentioned this issue Mar 16, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Fix default value of OPENTELEMETRY_INSTALL_default owent/opentelemetry-cpp
1 participant
@owent