-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Build break when using WITH_OTLP_HTTP=ON, WITH_OTLP_GRPC=OFF #1826
Comments
If I understand correctly, file Now the question remains to decide in which library to add file
Please advise on how to fix this. |
What about compiling this file only when Edit: you can also wrap contents of this file in something like |
bazel uses |
For bazel build, the new util code goes to a separate new lib, probably we could do the same for CMake? opentelemetry_exporter_otlp_grpc_client looks another acceptable place. https://github.com/open-telemetry/opentelemetry-cpp/blob/main/exporters/otlp/BUILD#L50 |
Have raised a PR by adding it to opentelemetry_exporter_otlp_grpc_client, it can be separate library too. I don't have strong preference for either. |
When compiling with the OTLP HTTP exporter but not the OTLP GRPC exporter,
the build fails:
Suggested fix for
exporter/otlp/CMakeLists.txt
:otlp_grpc_utils.cc
in theopentelemetry_otlp_recordable
libraryotlp_grpc_utils.cc
in theopentelemetry_exporter_otlp_grpc
library instead ? (to investigate)The text was updated successfully, but these errors were encountered: