Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Detection for container properties (e.g.container.id) #1661

Closed
svrnm opened this issue Oct 6, 2022 · 1 comment
Closed

Resource Detection for container properties (e.g.container.id) #1661

svrnm opened this issue Oct 6, 2022 · 1 comment
Labels

Comments

@svrnm
Copy link
Member

svrnm commented Oct 6, 2022

Is your feature request related to a problem?
Detecting the id of the container that holds the service instrumented with otel allows end-users to correlate container issues with service issues.

Describe the solution you'd like
A resource detector that can be added to the SDK and then does the reading of container.id for me automatically.

Describe alternatives you've considered
Injecting the container id via an environment variable is always possible.

Additional context
This will help with the documentation issue open-telemetry/opentelemetry.io#1818.

Similar implementations exist for JS, Java, .NET. The javascript one is the most advanced and provides all the pieces needed to extract container.id:

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/detectors/node/opentelemetry-resource-detector-container/src/detectors/ContainerDetector.ts

(Maybe this belongs into opentelemetry-cpp-contrib, so please move)

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 6, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant