Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module configtls #9377

Closed
8 tasks done
Tracked by #9375
codeboten opened this issue Jan 24, 2024 · 5 comments · Fixed by #10344
Closed
8 tasks done
Tracked by #9375

Stabilize module configtls #9377

codeboten opened this issue Jan 24, 2024 · 5 comments · Fixed by #10344

Comments

@codeboten
Copy link
Contributor

codeboten commented Jan 24, 2024

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases:

  • No open issues or PRs in the module that would require breaking changes
  • No TODOs in the module code that would require breaking changes
  • No deprecated symbols in the module
  • No symbols marked as experimental in the module
  • The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@atoulme
Copy link
Contributor

atoulme commented Jan 24, 2024

git grep TODO has no hits in the source code.

@atoulme
Copy link
Contributor

atoulme commented Mar 13, 2024

Announced at SIG meeting 3/13.

@atoulme
Copy link
Contributor

atoulme commented Jun 6, 2024

➜  configtls git:(main) git grep Deprecated
➜  configtls git:(main) git grep -i experimental

Neither return any results.

@atoulme
Copy link
Contributor

atoulme commented Jun 6, 2024

From my view, the only other issue associated with this module is ready to be marked as closed. I have opened a PR to move this module to stable and close this issue: #10344

mx-psi pushed a commit that referenced this issue Jul 2, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Mark module as stable.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #9377

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants