Add metric correctness support to testbed #1713
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 256 256
Lines 18190 18190
=======================================
Hits 16806 16806
Misses 970 970
Partials 414 414 Continue to review full report at Codecov.
|
pmcollins
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
|
@kbrockhoff can you review please? |
| @@ -0,0 +1,103 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
It seems this functionality should be in the testbed package like traces test case. It will need to be used for correctness tests in the contrib project.
There was a problem hiding this comment.
Discussed this with @pmcollins, I think we should not "overengineer" things. When we have a real need to use this in contrib, we should understand what is needed to be exported (public) and make the necessary changes. For the moment contrib is not using this.
There was a problem hiding this comment.
If that is the approach then this PR is fine. I will change my review status.
| @@ -0,0 +1,50 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
Same as above. Should be in testbed in form that can be used in contrib project.
| @@ -0,0 +1,37 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
This will also be used in contrib project.
| @@ -0,0 +1,110 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
This seems like functionality that should be distributed between existing testbed files. For example, compare function should be part of validator.
|
Thank you @kbrockhoff for your review. 🙏 Will address your comments in subsequent PRs. |
Migrate to using go.opentelemetry.io/proto/otlp
Description: This change adds support for end-to-end metrics correctness tests using generated PICT files.
Link to tracking Issue: #652
Documentation:
metrics/doc.go