Move tracing correctness into its own package #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
- Coverage 91.90% 91.88% -0.02%
==========================================
Files 254 254
Lines 17309 17309
==========================================
- Hits 15907 15905 -2
- Misses 1006 1007 +1
- Partials 396 397 +1
Continue to review full report at Codecov.
|
pmcollins
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
reviewed
Aug 22, 2020
|
Please rebase, there was an issue with Jaeger expired certificates |
This is for consistency with the metrics correctness package.
|
Hi @bogdandrutu, can you take a look? |
bogdandrutu
approved these changes
Aug 27, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update the SimpleSpanProcessor Subsequent calls to OnStart, OnEnd, and ForceFlush should be ignored gracefully once Shutdown has been called. This implements that behavior by shutting down the exporter and removing it from the SimpleSpanProcessor so subsequent calls to OnEnd will be no-ops. * Add changes to changelog * Lock in sync.Once of shutdown instead of Shutdown scope * Update CHANGELOG.md Co-authored-by: Steven E. Harris <seh@panix.com> * Release exporterMu before shutdown exporter * Move changes to unreleased section of changelog * Update simple_span_processor.go revert comment change from merge Co-authored-by: Steven E. Harris <seh@panix.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for consistency with the metrics correctness package.
We probably will want to update the name of the makefile target and the circle ci config that references it, but that could be done separately.
Description: To keep the correctness directory from getting too big, metrics correctness was put into its own package. Doing the same for tracing correctness.
Link to tracking Issue: #652
Testing: Ran
make testbed-correctnesslocally