Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should in-memory QueuedRetry exporter helper use requeuingEnabled=true? #7480

Closed
tigrannajaryan opened this issue Apr 3, 2023 · 3 comments
Closed
Labels
question Further information is requested

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Apr 3, 2023

Retry exporter helper does not have requeuingEnabled=true when in-memory queue is used. This results in data being dropped after after 5mins of retries (in default configuration).

What are the reasons why we think this is the right setting for the persistent queue but a wrong setting for the in-memory queue?

@dmitryax
Copy link
Member

dmitryax commented Apr 3, 2023

I'm not sure about the necessity of this option. If the backend is unavailable for a long time, the collector will be blocked and memory will never be freed. Maybe we should better propose what's being implemented in #7098 instead?

@tigrannajaryan tigrannajaryan changed the title In-memory QueuedRetry exporter helper must use requeuingEnabled=true Should in-memory QueuedRetry exporter helper use requeuingEnabled=true? Apr 3, 2023
@tigrannajaryan tigrannajaryan added question Further information is requested and removed bug Something isn't working labels Apr 3, 2023
@tigrannajaryan
Copy link
Member Author

I rephrased this as a question rather then a bug.

@dmitryax
Copy link
Member

dmitryax commented Jan 4, 2024

As part of #8382, the decision was made to remove the re-enquiring capability and rely on the back-off retry mechanism only. So the issue is not relevant anymore.

@dmitryax dmitryax closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants