-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to TLSSetting to not only read from file path, but from memory #7313
Comments
Do I understand correctly that this would mean I could configure a component that uses TLS (e.g. Prometheus exporter) like this, using environment variables? exporters:
prometheus:
tls:
cert: ${TLS_CERT} and pass the certificate content as environment variable |
I have created a prototype for this exact use case and would be willing to submit a similar PR if this proposal is accepted to move forward. Prototype: grafana#2 |
It looks like this was resolved, ok to close? |
I think we can close this indeed |
Is your feature request related to a problem? Please describe.
https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtls/configtls.go#L42
The current TLSSettting struct only reads CA cert, client/server cert and private key from file which is inconvenient in some situations. For instance, when deploying applications in a containerized environment, it may not be feasible to read from a file due to security and operational constraints.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would like to propose adding the ability to read the TLSSetting struct from memory in the OpenTelemetry library. This would enable applications to securely and conveniently provide the necessary TLS configuration settings without the need for an external file.
This could simply be adding a couple of new fields within the TLSSetting struct like the following
Alternatives Considered
We could work around this issue by reading from memory first and write to local files and then have TLSSetting pick up the generated files, but this is not a secure approach as if the private key doesn't get cleaned up property it could still be accessible by malicious parties.
The text was updated successfully, but these errors were encountered: