Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Factories to support new signals #3921

Closed
bogdandrutu opened this issue Aug 30, 2021 · 3 comments · Fixed by #4338
Closed

Allow Factories to support new signals #3921

bogdandrutu opened this issue Aug 30, 2021 · 3 comments · Fixed by #4338

Comments

@bogdandrutu
Copy link
Member

The current Factory implementation for Receiver, Exporter do not allow new signals because interfaces cannot be extended:

  1. Apply same model as https://github.com/open-telemetry/opentelemetry-collector/blob/main/component/processor.go#L117
  • There are few options: we do the simplest with a Base struct in the package OR force everyone to use the helpers (by making the internal method part of an interface in the internal package). At this point probably the simplest option is the best.
  1. Use optional interfaces - this is a larger change (tried it once) because lots of tests are using the interfaces.

Requirement: Solution needs to be applied to all Factory interfaces.

@bogdandrutu bogdandrutu added this to the Milestone-core-rc-release milestone Aug 30, 2021
@alolita
Copy link
Member

alolita commented Sep 2, 2021

@Aneurysm9 please take a look and file a PR :-)

@alolita alolita added the release:required-for-ga Must be resolved before GA release label Sep 2, 2021
@alolita alolita added area:exporter area:receiver and removed release:required-for-ga Must be resolved before GA release labels Sep 13, 2021
@mx-psi
Copy link
Member

mx-psi commented Oct 5, 2021

I would be happy to take this one if @Aneurysm9 is busy

@mx-psi
Copy link
Member

mx-psi commented Oct 6, 2021

Decided to give it a try since it was easy to do; happy to close if work was already being done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants