Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename service.Application.stopTestChan to service.Application.stopChan #3191

Closed
eddyleelin opened this issue May 16, 2021 · 0 comments
Closed

Rename service.Application.stopTestChan to service.Application.stopChan #3191

eddyleelin opened this issue May 16, 2021 · 0 comments
Assignees
@eddyleelin

Comments

@eddyleelin
Copy link
Contributor

As @tigrannajaryan mentioned in the previous issue #2260,

We should... rename stopTestChan to just stopChan. I can't see anything special about this stopping that is only applicable to tests. It is just a way to stop the service.

Originally posted by @tigrannajaryan in #2260 (comment)

If this is a valid issue, I could take this one on! Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyleelin eddyleelin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddyleelin