Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validate to configmodels interfaces (e.g. configmodels.Processor) #2541

Closed
bogdandrutu opened this issue Feb 24, 2021 · 3 comments
Closed
Assignees
Labels
area:config good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@bogdandrutu
Copy link
Member

In order for the collector to be able to verify the config without creating components we need to validate every config before calling New on the factory.

This way we can add a flag like "--dry-run" that verifies the configuration, also we can ensure that we fail fast, etc.

@bogdandrutu bogdandrutu added this to the Phase1-GA-Roadmap milestone Feb 24, 2021
@bogdandrutu bogdandrutu added area:config good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up labels Mar 3, 2021
@alolita
Copy link
Member

alolita commented Mar 11, 2021

@bogdandrutu can you please assign @mxiamxia to this issue. I don't have rights to assign.

When the Collector is initialized, there is already basic configuration validation. Can you provide more detail on what else needs to be added for verification?

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Mar 11, 2021

Few things here:

  1. @mxiamxia is not part of opentelemetry org which you should fix. Cannot assign to him unless he comments on this issue otherwise.
  2. I am talking about adding this func to the configmodels.[Receiver|Exporter|Processor|Extension] so components can provide custom verification logic for their own config.

@bogdandrutu bogdandrutu changed the title Add Verify to configmodels interfaces (e.g. configmodels.Processor) Add Validate to configmodels interfaces (e.g. configmodels.Processor) Mar 18, 2021
@alolita
Copy link
Member

alolita commented Mar 18, 2021

@mxiamxia See #2597 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

3 participants