-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.111.0 broke: "service/telemetry/internal/otelinit/config.go" #11478
Comments
Hey, thanks for reporting, all tests are passing in our CI, would you mind giving more details about what command are you running and whether you are making any modifications to the code? |
No modifications to the code have been made. I'm simply consuming this go package and running If you look in the above commit, you should notice that I believe some files have not been updated, which are causing these errors. Perhaps your CI isn't failing, because the above
|
Another example of a CI command that fails: Command: |
I expect this is caused by a transitive dependency. What version of the |
Thanks for the advice. Adding this line to my
So, is the solution here to leave this |
They will probably not fix the breaking and will keep it. What will happen is we need to adopt our code to use the new version. Closing this, since this is expected per the situation described. |
Describe the bug
re: go.opentelemetry.io/collector/service@v0.111.0/telemetry/internal/otelinit/config.go
As a result of this PR: #11205
Tagging @bogdandrutu for awareness^
go build/test fails with multiple undefined/undeclared-imported-name.
Steps to reproduce
Upgrade OTEL go project from v0.110.0 -> v0.111.0, go project now fails to test/build with above errors.
What did you expect to see?
Successful go test/build without regression
What did you see instead?
See above error messages
What version did you use?
v0.111.0 (working fine in v0.110.0)
What config did you use?
I updated my yaml as per: #11205 from:
to the following:
but on gotest/gobuild, I then hit the above errors, also caught by
go-analysis
viagolangci-lint
Environment
Ubuntu 22.04.5
go 1.23.2
Additional context
None
The text was updated successfully, but these errors were encountered: