You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,While working on an issue of Jaeger to clean up grpc logs which is :- jaegertracing/jaeger#5784
The logs are all tagged with zapgrpc/zapgrpc.go:176. This indicates that the Skip() parameter is incorrect when a gRPC logger is
instantiated.
...
2024-07-28T16:17:24.271-0400 info zapgrpc/zapgrpc.go:176 [core] original dial target is: "localhost:4317" {"grpc_log": true}
2024-07-28T16:17:24.271-0400 info zapgrpc/zapgrpc.go:176 [core] [Channel #1]Channel created {"grpc_log": true}
2024-07-28T16:17:24.271-0400 info zapgrpc/zapgrpc.go:176 [core] [Channel #1]parsed dial target is: resolver.Target{URL:url.URL{Scheme:"dns
on furthur digging it seems to be an issue in the grpclog logger i.e. otelcol>internal>grpclog>logger.go which seems to be missing an AddSkipCaller() which is causing logs to be tagged with zapgrpc/zapgrpc.go:176 instead of the real location of the log statements. Steps to reproduce
What did you expect to see?
Logs printing actual locations of the log statements
What did you see instead?
All logs of grpclogger printing zapgrpc/zapgrpc.go:176
What version did you use?
Version: 0.106.0
What config did you use?
Environment
MacOS 14.2.1
Additional context
The text was updated successfully, but these errors were encountered:
Hello,While working on an issue of Jaeger to clean up grpc logs which is :-
jaegertracing/jaeger#5784
The logs are all tagged with zapgrpc/zapgrpc.go:176. This indicates that the Skip() parameter is incorrect when a gRPC logger is
instantiated.
on furthur digging it seems to be an issue in the grpclog logger i.e. otelcol>internal>grpclog>logger.go which seems to be missing an AddSkipCaller() which is causing logs to be tagged with zapgrpc/zapgrpc.go:176 instead of the real location of the log statements.
Steps to reproduce
What did you expect to see?
Logs printing actual locations of the log statements
What did you see instead?
All logs of grpclogger printing zapgrpc/zapgrpc.go:176
What version did you use?
Version: 0.106.0
What config did you use?
Environment
MacOS 14.2.1
Additional context
The text was updated successfully, but these errors were encountered: