Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up gRPC logging #10772

Closed
vvs-personalstash opened this issue Jul 31, 2024 · 0 comments · Fixed by #10773
Closed

Clean up gRPC logging #10772

vvs-personalstash opened this issue Jul 31, 2024 · 0 comments · Fixed by #10773
Labels
bug Something isn't working

Comments

@vvs-personalstash
Copy link
Contributor

Hello,While working on an issue of Jaeger to clean up grpc logs which is :-
jaegertracing/jaeger#5784
The logs are all tagged with zapgrpc/zapgrpc.go:176. This indicates that the Skip() parameter is incorrect when a gRPC logger is
instantiated.

...
2024-07-28T16:17:24.271-0400	info	zapgrpc/zapgrpc.go:176	[core] original dial target is: "localhost:4317"	{"grpc_log": true}
2024-07-28T16:17:24.271-0400	info	zapgrpc/zapgrpc.go:176	[core] [Channel #1]Channel created	{"grpc_log": true}
2024-07-28T16:17:24.271-0400	info	zapgrpc/zapgrpc.go:176	[core] [Channel #1]parsed dial target is: resolver.Target{URL:url.URL{Scheme:"dns

on furthur digging it seems to be an issue in the grpclog logger i.e. otelcol>internal>grpclog>logger.go which seems to be missing an AddSkipCaller() which is causing logs to be tagged with zapgrpc/zapgrpc.go:176 instead of the real location of the log statements.
Steps to reproduce

What did you expect to see?
Logs printing actual locations of the log statements

What did you see instead?
All logs of grpclogger printing zapgrpc/zapgrpc.go:176

What version did you use?
Version: 0.106.0

What config did you use?

Environment
MacOS 14.2.1

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant