-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelcol] confmap ResolverSettings should retain all features custom config provider has #10005
Comments
Hey @evan-bradley and @mx-psi , I filed a github issue here to follow up with the discussion from #9228 |
Thanks for opening this @splunkericl. Could you provide more details on why you need a custom |
Is the latest recommended approach to trigger the passed in |
That's my understanding, yes. I will let others chime in here if they know more about how this may change in the future. At a minimum, I expect reload functionality to be provided through the I think the design likely needs another review and the docs should be updated, but you can see a description for |
Agreed with @evan-bradley's analysis here. @splunkericl, if there are still remaining features that are not available under the new API, could you write a minimal example that showcases them? |
@mx-psi I think this is fine as long as it is backward compatible. Thanks for the confirmations |
@splunkericl It sounds like you're good, so I'm going to close this for now. If you see any other issues with the new API as you adopt it, please let us know. |
Describe the bug
As part of #9228, custom
configProvider
is being deprecated from the collector.The main proposal was to move all features from
configProvider
to derive fromconfmap.ResolverSettings
. However, one feature that was missing was that customconfigProvider
allows users to provide a a customWatch
method, which allows notifying the collector framework of settings update. This is a crucial use case of our product as we update out settings dynamically.Steps to reproduce
configProvider
toconfmap.ResolverSettings
What did you expect to see?
confmap.ResolverSettings
What did you see instead?
configProvider
is deprecatedWhat version did you use?
starting v0.95
What config did you use?
N/A
Environment
mac sonoma 14.2.1
Additional context
The text was updated successfully, but these errors were encountered: