diff --git a/Makefile b/Makefile index 3fe52341fbf..556e6a25d34 100644 --- a/Makefile +++ b/Makefile @@ -19,6 +19,8 @@ MISSPELL=misspell -error MISSPELL_CORRECTION=misspell -w LINT=golangci-lint IMPI=impi +GOSEC=gosec +STATIC_CHECK=staticcheck GIT_SHA=$(shell git rev-parse --short HEAD) BUILD_INFO_IMPORT_PATH=github.com/open-telemetry/opentelemetry-collector/internal/version @@ -89,8 +91,23 @@ misspell: misspell-correction: $(MISSPELL_CORRECTION) $(ALL_DOC) +.PHONY: lint-gosec +lint-gosec: + $(GOSEC) -quiet -exclude=G104,G107 ./... + +.PHONY: lint-static-check +lint-static-check: + @STATIC_CHECK_OUT=`$(STATIC_CHECK) ./... 2>&1`; \ + if [ "$$STATIC_CHECK_OUT" ]; then \ + echo "$(STATIC_CHECK) FAILED => static check errors:\n"; \ + echo "$$STATIC_CHECK_OUT\n"; \ + exit 1; \ + else \ + echo "Static check finished successfully"; \ + fi + .PHONY: lint -lint: +lint: lint-static-check $(LINT) run .PHONY: impi @@ -99,11 +116,12 @@ impi: .PHONY: install-tools install-tools: - GO111MODULE=on go install \ - github.com/google/addlicense \ - github.com/golangci/golangci-lint/cmd/golangci-lint \ - github.com/client9/misspell/cmd/misspell \ - github.com/pavius/impi/cmd/impi + go install github.com/google/addlicense + go install github.com/golangci/golangci-lint/cmd/golangci-lint + go install github.com/client9/misspell/cmd/misspell + go install github.com/pavius/impi/cmd/impi + go install github.com/securego/gosec/cmd/gosec + go install honnef.co/go/tools/cmd/staticcheck .PHONY: otelcol otelcol: diff --git a/exporter/exportertest/sink_exporter.go b/exporter/exportertest/sink_exporter.go index 777951db735..6241f0995fb 100644 --- a/exporter/exportertest/sink_exporter.go +++ b/exporter/exportertest/sink_exporter.go @@ -48,11 +48,6 @@ func (ste *SinkTraceExporter) ConsumeTraceData(ctx context.Context, td consumerd return nil } -const ( - sinkTraceExportFormat = "sink_trace" - sinkMetricsExportFormat = "sink_metrics" -) - // AllTraces returns the traces sent to the test sink. func (ste *SinkTraceExporter) AllTraces() []consumerdata.TraceData { ste.mu.Lock() diff --git a/exporter/otlpexporter/connection.go b/exporter/otlpexporter/connection.go index 9b9437396ad..3a14ebd68aa 100644 --- a/exporter/otlpexporter/connection.go +++ b/exporter/otlpexporter/connection.go @@ -30,14 +30,6 @@ import ( // Connection implementation is borrowed and adapted from OpenTelemetry Go SDK implementation: // https://github.com/open-telemetry/opentelemetry-go/blob/e0406dd3eb7aa826aba19287e8a14ca016bf8578/exporters/otlp/connection.go#L15 -func (e *exporterImp) lastConnectError() error { - errPtr := (*error)(atomic.LoadPointer(&e.lastConnectErrPtr)) - if errPtr == nil { - return nil - } - return *errPtr -} - func (e *exporterImp) saveLastConnectError(err error) { var errPtr *error if err != nil { @@ -58,10 +50,6 @@ func (e *exporterImp) setStateConnected() { e.saveLastConnectError(nil) } -func (e *exporterImp) connected() bool { - return e.lastConnectError() == nil -} - const defaultConnReattemptPeriod = 10 * time.Second func (e *exporterImp) indefiniteBackgroundConnection() { diff --git a/exporter/otlpexporter/exporter.go b/exporter/otlpexporter/exporter.go index 0a03c790f77..497b8920199 100644 --- a/exporter/otlpexporter/exporter.go +++ b/exporter/otlpexporter/exporter.go @@ -62,9 +62,9 @@ type exporterImp struct { var ( errAlreadyStarted = errors.New("already started") errNotStarted = errors.New("not started") - errTimeout = errors.New("Timeout") - errStopped = errors.New("Stopped") - errFatalError = errors.New("Fatal error sending to server") + errTimeout = errors.New("timeout") + errStopped = errors.New("stopped") + errFatalError = errors.New("fatal error sending to server") ) // Crete new exporter and start it. The exporter will begin connecting but diff --git a/go.mod b/go.mod index bc2590caf4a..f01f269f622 100644 --- a/go.mod +++ b/go.mod @@ -39,6 +39,7 @@ require ( github.com/prometheus/procfs v0.0.3 github.com/prometheus/prometheus v1.8.2-0.20190924101040-52e0504f83ea github.com/rs/cors v1.6.0 + github.com/securego/gosec v0.0.0-20200316084457-7da9f46445fd github.com/soheilhy/cmux v0.1.4 github.com/spf13/cast v1.3.0 github.com/spf13/cobra v0.0.5 @@ -51,11 +52,12 @@ require ( github.com/uber/tchannel-go v1.10.0 go.opencensus.io v0.22.1 go.uber.org/zap v1.10.0 - golang.org/x/sys v0.0.0-20190922100055-0a153f010e69 + golang.org/x/sys v0.0.0-20191120155948-bd437916bb0e google.golang.org/api v0.10.0 // indirect google.golang.org/genproto v0.0.0-20190801165951-fa694d86fc64 google.golang.org/grpc v1.23.0 - gopkg.in/yaml.v2 v2.2.4 + gopkg.in/yaml.v2 v2.2.8 + honnef.co/go/tools v0.0.1-2019.2.3 k8s.io/client-go v12.0.0+incompatible // indirect ) diff --git a/go.sum b/go.sum index 21b64496d7f..34b9c72b416 100644 --- a/go.sum +++ b/go.sum @@ -480,6 +480,7 @@ github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lN github.com/modern-go/reflect2 v1.0.1 h1:9f412s+6RmYXLWZSEzVVgPGK7C2PphHj5RJrvfx9AWI= github.com/modern-go/reflect2 v1.0.1/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0= github.com/mozilla/tls-observatory v0.0.0-20190404164649-a3c1b6cfecfd/go.mod h1:SrKMQvPiws7F7iqYp8/TX+IhxCYhzr6N/1yb8cwHsGk= +github.com/mozilla/tls-observatory v0.0.0-20200220173314-aae45faa4006/go.mod h1:SrKMQvPiws7F7iqYp8/TX+IhxCYhzr6N/1yb8cwHsGk= github.com/munnerz/goautoneg v0.0.0-20120707110453-a547fc61f48d/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ= github.com/mwitkow/go-conntrack v0.0.0-20161129095857-cc309e4a2223 h1:F9x/1yl3T2AeKLr2AMdilSD8+f9bvMnNN8VS5iDtovc= github.com/mwitkow/go-conntrack v0.0.0-20161129095857-cc309e4a2223/go.mod h1:qRWi+5nqEBWmkhHvq77mSJWrCKwh8bxhgT7d/eI7P4U= @@ -500,6 +501,8 @@ github.com/onsi/ginkgo v1.8.0 h1:VkHVNpR4iVnU8XQR6DBm8BqYjN7CRzw+xKUbVVbbW9w= github.com/onsi/ginkgo v1.8.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= github.com/onsi/ginkgo v1.10.1 h1:q/mM8GF/n0shIN8SaAZ0V+jnLPzen6WIVZdiwrRlMlo= github.com/onsi/ginkgo v1.10.1/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= +github.com/onsi/ginkgo v1.12.0 h1:Iw5WCbBcaAAd0fpRb1c9r5YCylv4XDoCSigm1zLevwU= +github.com/onsi/ginkgo v1.12.0/go.mod h1:oUhWkIvk5aDxtKvDDuw8gItl8pKl42LzjC9KZE0HfGg= github.com/onsi/gomega v0.0.0-20170829124025-dcabb60a477c/go.mod h1:C1qb7wdrVGGVU+Z6iS04AVkA3Q65CEZX59MT0QO5uiA= github.com/onsi/gomega v0.0.0-20190113212917-5533ce8a0da3/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= github.com/onsi/gomega v1.4.3 h1:RE1xgDvH7imwFD45h+u2SgIfERHlS2yNG4DObb5BSKU= @@ -508,6 +511,9 @@ github.com/onsi/gomega v1.5.0 h1:izbySO9zDPmjJ8rDjLvkA2zJHIo+HkYXHnf7eN7SSyo= github.com/onsi/gomega v1.5.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= github.com/onsi/gomega v1.7.0 h1:XPnZz8VVBHjVsy1vzJmRwIcSwiUO+JFfrv/xGiigmME= github.com/onsi/gomega v1.7.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= +github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY= +github.com/onsi/gomega v1.9.0 h1:R1uwffexN6Pr340GtYRIdZmAiN4J+iw6WG4wog1DUXg= +github.com/onsi/gomega v1.9.0/go.mod h1:Ho0h+IUsWyvy1OpqCwxlQ/21gkhVunqlU8fDGcoTdcA= github.com/open-telemetry/opentelemetry-proto v0.0.0-20200316171511-e76584d22418 h1:R4Mjk1d++Hke9e4W33O6CMUS85hALRP5wKjhaeCYuSk= github.com/open-telemetry/opentelemetry-proto v0.0.0-20200316171511-e76584d22418/go.mod h1:PMR5GI0F7BSpio+rBGFxNm6SLzg3FypDTcFuQZnO+F8= github.com/opentracing-contrib/go-stdlib v0.0.0-20190519235532-cf7a6c988dc9/go.mod h1:PLldrQSroqzH70Xl+1DQcGnefIbqsKR7UDaiux3zV+w= @@ -597,6 +603,9 @@ github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529 h1:nn5Wsu0esKSJiIVhscUt github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod h1:DxrIzT+xaE7yg65j358z/aeFdxmN0P9QXhEzd20vsDc= github.com/securego/gosec v0.0.0-20191002120514-e680875ea14d h1:BzRvVq1EHuIjxpijCEKpAxzKUUMurOQ4sknehIATRh8= github.com/securego/gosec v0.0.0-20191002120514-e680875ea14d/go.mod h1:w5+eXa0mYznDkHaMCXA4XYffjlH+cy1oyKbfzJXa2Do= +github.com/securego/gosec v0.0.0-20200316084457-7da9f46445fd h1:qB+l4fYZsH78xORC1aqVS0zNmgkQp4rkj2rvfxQMtzc= +github.com/securego/gosec v0.0.0-20200316084457-7da9f46445fd/go.mod h1:NurAFZsWJAEZjogSwdVPlHkOZB3DOAU7gsPP8VFZCHc= +github.com/shirou/gopsutil v0.0.0-20190901111213-e4ec7b275ada h1:WokF3GuxBeL+n4Lk4Fa8v9mbdjlrl7bHuneF4N1bk2I= github.com/shirou/gopsutil v0.0.0-20190901111213-e4ec7b275ada/go.mod h1:WWnYX4lzhCH5h/3YBfyVA3VbLYjlMZZAQcW9ojMexNc= github.com/shirou/w32 v0.0.0-20160930032740-bb4de0191aa4/go.mod h1:qsXQc7+bwAM3Q1u/4XEfrquwF8Lw7D7y5cD8CuHnfIc= github.com/shurcooL/go v0.0.0-20180423040247-9e1955d9fb6e h1:MZM7FHLqUHYI0Y/mQAt3d2aYa0SiNms/hFqC9qJYolM= @@ -716,6 +725,8 @@ golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 h1:HuIa8hRrWRSrqYzx1qI49N golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/crypto v0.0.0-20190923035154-9ee001bba392 h1:ACG4HJsFiNMf47Y4PeRoebLNy/2lXT9EtprMuTFWt1M= golang.org/x/crypto v0.0.0-20190923035154-9ee001bba392/go.mod h1:/lpIB1dKB+9EgE3H3cr1v9wB50oz8l4C4h62xy7jSTY= +golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 h1:ObdrDkeb4kJdCP557AjRjq69pTHfNouLtWZG7j9rPN8= +golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8= golang.org/x/image v0.0.0-20190227222117-0694c2d4d067/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js= @@ -726,8 +737,11 @@ golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3 h1:XQyxROzUlZH+WIQwySDgnISg golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3/go.mod h1:6SW0HCj/g11FgYtHlgUYUwCkIfeOF89ocIRzGO/8vkc= golang.org/x/lint v0.0.0-20190409202823-959b441ac422 h1:QzoH/1pFpZguR8NrRHLcO6jKqfv2zpuSqZLgdm7ZmjI= golang.org/x/lint v0.0.0-20190409202823-959b441ac422/go.mod h1:6SW0HCj/g11FgYtHlgUYUwCkIfeOF89ocIRzGO/8vkc= +golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f/go.mod h1:5qLYkcX4OjUUV8bRuDixDT3tpyyb+LUpUlRWLxfhWrs= golang.org/x/mobile v0.0.0-20190312151609-d3739f865fa6/go.mod h1:z+o9i4GpDbdi3rU15maQ/Ox0txvL9dWGYEHz965HBQE= golang.org/x/mod v0.0.0-20190513183733-4bf6d317e70e/go.mod h1:mXi4GBBbnImb6dmsKGUJ2LatrhH/nqhxcFungHvyanc= +golang.org/x/mod v0.1.1-0.20191105210325-c90efee705ee h1:WG0RUwxtNT4qqaXX3DPA8zHFNm/D9xaBpxzHt1WcA/E= +golang.org/x/mod v0.1.1-0.20191105210325-c90efee705ee/go.mod h1:QqPTAvyqsEbceGzBzNggFXnrqF1CaUcvgkdR5Ot7KZg= golang.org/x/net v0.0.0-20170114055629-f2499483f923/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= @@ -812,6 +826,8 @@ golang.org/x/sys v0.0.0-20190813064441-fde4db37ae7a h1:aYOabOQFp6Vj6W1F80affTUvO golang.org/x/sys v0.0.0-20190813064441-fde4db37ae7a/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190922100055-0a153f010e69 h1:rOhMmluY6kLMhdnrivzec6lLgaVbMHMn2ISQXJeJ5EM= golang.org/x/sys v0.0.0-20190922100055-0a153f010e69/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20191120155948-bd437916bb0e h1:N7DeIrjYszNmSW409R3frPPwglRwMkXSBzwVbkOjLLA= +golang.org/x/sys v0.0.0-20191120155948-bd437916bb0e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.0.0-20160726164857-2910a502d2bf/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= @@ -855,7 +871,12 @@ golang.org/x/tools v0.0.0-20190910044552-dd2b5c81c578/go.mod h1:b+2E5dAYhXwXZwtn golang.org/x/tools v0.0.0-20190930201159-7c411dea38b0/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo= golang.org/x/tools v0.0.0-20191010075000-0337d82405ff h1:XdBG6es/oFDr1HwaxkxgVve7NB281QhxgK/i4voubFs= golang.org/x/tools v0.0.0-20191010075000-0337d82405ff/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo= +golang.org/x/tools v0.0.0-20191125144606-a911d9008d1f/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo= +golang.org/x/tools v0.0.0-20200228224639-71482053b885 h1:y09Juz/HD0YjGlyEd4bLUWG0s8Yx6iPniPqUGzUxNrU= +golang.org/x/tools v0.0.0-20200228224639-71482053b885/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28= golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= +golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898 h1:/atklqdjdhuosWIl6AIbOeHJjicWYPqR9bpxqxYG2pA= +golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= google.golang.org/api v0.4.0 h1:KKgc1aqhV8wDPbDzlDtpvyjZFY3vjz85FP7p4wcQUyI= google.golang.org/api v0.4.0/go.mod h1:8k5glujaEP+g9n7WNsDg8QP6cUVNI86fCNMcbazEtwE= google.golang.org/api v0.7.0 h1:9sdfJOzWlkqPltHAuzT2Cp+yrBeY1KRVYgms8soxMwM= @@ -919,6 +940,8 @@ gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw= gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= gopkg.in/yaml.v2 v2.2.4 h1:/eiJrUcujPVeJ3xlSWaiNi3uSVmDGBK1pDHUHAnao1I= gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= +gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10= +gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4= honnef.co/go/tools v0.0.0-20190106161140-3f1c8253044a h1:/8zB6iBfHCl1qAnEAWwGPNrUvapuy6CPla1VM0k8hQw= honnef.co/go/tools v0.0.0-20190106161140-3f1c8253044a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4= diff --git a/internal/data/common.go b/internal/data/common.go index a73f2a939e2..d28899116ae 100644 --- a/internal/data/common.go +++ b/internal/data/common.go @@ -173,7 +173,7 @@ func (akv AttributeKeyValue) Key() string { // Value returns the value associated with this AttributeKeyValue. func (akv AttributeKeyValue) Value() AttributeValue { - return AttributeValue{akv.orig} + return AttributeValue(akv) } // SetValue replaces the value associated with this AttributeKeyValue. diff --git a/internal/tools.go b/internal/tools.go index 3bbf041226a..60f2962ce52 100644 --- a/internal/tools.go +++ b/internal/tools.go @@ -28,4 +28,6 @@ import ( _ "github.com/google/addlicense" _ "github.com/jstemmer/go-junit-report" _ "github.com/pavius/impi/cmd/impi" + _ "github.com/securego/gosec/cmd/gosec" + _ "honnef.co/go/tools/cmd/staticcheck" ) diff --git a/receiver/jaegerreceiver/config_test.go b/receiver/jaegerreceiver/config_test.go index 70709e93469..b667b01dbae 100644 --- a/receiver/jaegerreceiver/config_test.go +++ b/receiver/jaegerreceiver/config_test.go @@ -176,5 +176,5 @@ func TestFailedLoadConfig(t *testing.T) { assert.EqualError(t, err, `error reading settings for receiver type "jaeger": must specify at least one protocol when using the Jaeger receiver`) _, err = config.LoadConfigFile(t, path.Join(".", "testdata", "bad_empty_config.yaml"), factories) - assert.EqualError(t, err, `error reading settings for receiver type "jaeger": Jaeger receiver config is empty`) + assert.EqualError(t, err, `error reading settings for receiver type "jaeger": empty config for Jaeger receiver`) } diff --git a/receiver/jaegerreceiver/factory.go b/receiver/jaegerreceiver/factory.go index 73662d37e01..bc9cae5e916 100644 --- a/receiver/jaegerreceiver/factory.go +++ b/receiver/jaegerreceiver/factory.go @@ -82,7 +82,7 @@ func (f *Factory) CustomUnmarshaler() receiver.CustomUnmarshaler { // these protocols were excluded during normal loading and we need to add defaults for them vSub := v.Sub(viperKey) if vSub == nil { - return fmt.Errorf("Jaeger receiver config is empty") + return fmt.Errorf("empty config for Jaeger receiver") } protocols := vSub.GetStringMap(protocolsFieldName) if len(protocols) == 0 { diff --git a/translator/internaldata/traces_to_oc.go b/translator/internaldata/traces_to_oc.go index 3222a92f96d..4cb558a1141 100644 --- a/translator/internaldata/traces_to_oc.go +++ b/translator/internaldata/traces_to_oc.go @@ -267,7 +267,7 @@ func eventToOC(event data.SpanEvent) *octrace.Span_TimeEvent { } if ocMessageEventAttrFound { ocMessageEventType := ocMessageEventAttrValues[conventions.OCTimeEventMessageEventType] - ocMessageEventTypeVal, _ := octrace.Span_TimeEvent_MessageEvent_Type_value[ocMessageEventType.StringVal()] + ocMessageEventTypeVal := octrace.Span_TimeEvent_MessageEvent_Type_value[ocMessageEventType.StringVal()] return &octrace.Span_TimeEvent{ Time: internal.UnixnanoToTimestamp(event.Timestamp()), Value: &octrace.Span_TimeEvent_MessageEvent_{ diff --git a/translator/metrics/otlp_to_oc.go b/translator/metrics/otlp_to_oc.go index 45ee91a83ec..2030b5fa99b 100644 --- a/translator/metrics/otlp_to_oc.go +++ b/translator/metrics/otlp_to_oc.go @@ -106,7 +106,7 @@ func labelKeysToOC(metric *otlpmetrics.Metric) *labelKeys { // to preserve 1:1 matching between label keys and values. // First, collect a set of all labels present in the metric - keySet := make(map[string]struct{}, 0) + keySet := make(map[string]struct{}) for _, point := range metric.Int64DataPoints { addLabelKeys(keySet, point.Labels) } diff --git a/translator/opencensus/oc_to_internal_test.go b/translator/opencensus/oc_to_internal_test.go index 89b1b4d7e01..6bc1b26c8c5 100644 --- a/translator/opencensus/oc_to_internal_test.go +++ b/translator/opencensus/oc_to_internal_test.go @@ -90,7 +90,7 @@ func TestOcNodeResourceToInternal(t *testing.T) { for i := 0; i < expectedAttrs.Len(); i++ { // Set all except "attr1" which is not a hard-coded field to some bogus values. - if strings.Index(expectedAttrs.GetAttribute(i).Key(), "-attr") < 0 { + if !strings.Contains(expectedAttrs.GetAttribute(i).Key(), "-attr") { ocNode.Attributes[expectedAttrs.GetAttribute(i).Key()] = "this will be overridden 1" } } diff --git a/translator/trace/oc_to_otlp_test.go b/translator/trace/oc_to_otlp_test.go index 1811c4bb4d8..727f1312deb 100644 --- a/translator/trace/oc_to_otlp_test.go +++ b/translator/trace/oc_to_otlp_test.go @@ -114,7 +114,7 @@ func TestOcNodeResourceToOtlp(t *testing.T) { for k := range expectedAttrs { // Set all except "attr1" which is not a hard-coded field to some bogus values. - if strings.Index(k, "-attr") < 0 { + if !strings.Contains(k, "-attr") { node.Attributes[k] = "this will be overridden 1" } }