From 359032cb277c2dbddaf6b8f5f2394d323f4715bb Mon Sep 17 00:00:00 2001 From: Ziqi Zhao Date: Fri, 25 Aug 2023 20:27:18 +0800 Subject: [PATCH] [pkg/pdatatest] enable exhaustive lint Signed-off-by: Ziqi Zhao --- pkg/pdatatest/pmetrictest/metrics.go | 1 + pkg/pdatatest/pmetrictest/options.go | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/pkg/pdatatest/pmetrictest/metrics.go b/pkg/pdatatest/pmetrictest/metrics.go index f795ea004e10..48a3cc971189 100644 --- a/pkg/pdatatest/pmetrictest/metrics.go +++ b/pkg/pdatatest/pmetrictest/metrics.go @@ -240,6 +240,7 @@ func CompareMetric(expected pmetric.Metric, actual pmetric.Metric) error { return errs } + //exhaustive:enforce switch actual.Type() { case pmetric.MetricTypeGauge: errs = multierr.Append(errs, compareNumberDataPointSlices(expected.Gauge().DataPoints(), diff --git a/pkg/pdatatest/pmetrictest/options.go b/pkg/pdatatest/pmetrictest/options.go index cf52d633cd52..3248a82029f9 100644 --- a/pkg/pdatatest/pmetrictest/options.go +++ b/pkg/pdatatest/pmetrictest/options.go @@ -59,6 +59,7 @@ func maskMetricSliceValues(metrics pmetric.MetricSlice, metricNames ...string) { func getDataPointSlice(metric pmetric.Metric) pmetric.NumberDataPointSlice { var dataPointSlice pmetric.NumberDataPointSlice + //exhaustive:enforce switch metric.Type() { case pmetric.MetricTypeGauge: dataPointSlice = metric.Gauge().DataPoints() @@ -96,6 +97,7 @@ func maskTimestamp(metrics pmetric.Metrics, ts pcommon.Timestamp) { for j := 0; j < rms.At(i).ScopeMetrics().Len(); j++ { for k := 0; k < rms.At(i).ScopeMetrics().At(j).Metrics().Len(); k++ { m := rms.At(i).ScopeMetrics().At(j).Metrics().At(k) + //exhaustive:enforce switch m.Type() { case pmetric.MetricTypeGauge: for l := 0; l < m.Gauge().DataPoints().Len(); l++ { @@ -139,6 +141,7 @@ func maskStartTimestamp(metrics pmetric.Metrics, ts pcommon.Timestamp) { for j := 0; j < rms.At(i).ScopeMetrics().Len(); j++ { for k := 0; k < rms.At(i).ScopeMetrics().At(j).Metrics().Len(); k++ { m := rms.At(i).ScopeMetrics().At(j).Metrics().At(k) + //exhaustive:enforce switch m.Type() { case pmetric.MetricTypeGauge: for l := 0; l < m.Gauge().DataPoints().Len(); l++ { @@ -392,6 +395,7 @@ func sortMetricDataPointSlices(ms pmetric.Metrics) { for j := 0; j < ms.ResourceMetrics().At(i).ScopeMetrics().Len(); j++ { for k := 0; k < ms.ResourceMetrics().At(i).ScopeMetrics().At(j).Metrics().Len(); k++ { m := ms.ResourceMetrics().At(i).ScopeMetrics().At(j).Metrics().At(k) + //exhaustive:enforce switch m.Type() { case pmetric.MetricTypeGauge: sortNumberDataPointSlice(m.Gauge().DataPoints())