[chore] [cmd/mdatagen] Separate configuration generation #21516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
djaglowski,
codeboten,
atoulme,
dashpole,
MovieStoreGuy and
Aneurysm9
as code owners
github-actions
bot
added
cmd/mdatagen
github-actions
bot
requested review from
altuner,
antonblock,
BinaryFissionGames,
jamesmoessis,
JonathanWamsley and
rmfitzpatrick
dmitryax
force-pushed
the
mdatagen-make-resource-attributes-configurable
branch
2 times, most recently
from
bf64f3c to
6ffad79
Compare
- Render the configuration separately - Add config tests - Allow setting `resource_attributes` group in metadata.yaml which will result in generation of the config related to resource attributes. - Remove redundant NewMetricsBuilderConfig func - Don't include resource_attributes config option in user interface if there are no resource attributes defined
dmitryax
force-pushed
the
mdatagen-make-resource-attributes-configurable
branch
from
6ffad79 to
86395fb
Compare
|
I'm going to split PR. Turning into a draft for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource_attributesgroup in metadata.yaml which will result in the generation of the config structs related to resource attributes. The generated config can be used in non-scraping components likeresourcedetectionprocessor as proposed in [processor/resourcedetection] Proposal: default/optional resource attributes per detector #21482resource_attributesconfig option in user interface if there are no resource attributes defined