Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set span's Status #4754

Closed
iNikem opened this issue Jul 6, 2021 · 6 comments
Closed

Allow to set span's Status #4754

iNikem opened this issue Jul 6, 2021 · 6 comments

Comments

@iNikem
Copy link
Contributor

iNikem commented Jul 6, 2021

OpenTelemetry spec currently says the following in the description of Span.SetStatus method:

Application developers and Operators may set the status code to Ok.

From the previous discussions on this topic I assumed that the way for Operator to set span status is by using Collector. Unfortunately, Collector does not support setting span status atm. Span Processor supports only changing span name and Attributes Processor, naturally, operate only on attributes and cannot change status.

Proposed solution is to expand Span Processor and to allow it to change span status.

@billg-splunk
Copy link

It seems like a pretty big deal to be able to support this. In some contexts a 4xx error is not considered an error. But with no way to easily alter the status it causes an error behavior regardless. This brings with it false-positives.

@jshawatsplunk
Copy link

I too have users who do not consider 4xx as errors of interest. Control over such configuration would be very welcomed.

@bogdandrutu bogdandrutu transferred this issue from open-telemetry/opentelemetry-collector Aug 20, 2021
@kdroukman
Copy link

Adding my vote to this. The rigid specification around the span status doesn't allow for a variety of use cases in the real world, with the most common request being the ability to override error classification of 4xx status codes.

@iNikem
Copy link
Contributor Author

iNikem commented Aug 25, 2021

@bogdandrutu why did you move this issue into contrib? Changing attribute values is the core functionality of the Collector. Changing status value should be the same, no?

@TomRoSystems
Copy link
Member

Please assign this ticket to me.

@iNikem
Copy link
Contributor Author

iNikem commented Jan 3, 2022

Fixed by #5886

@iNikem iNikem closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants