-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set span's Status #4754
Comments
It seems like a pretty big deal to be able to support this. In some contexts a 4xx error is not considered an error. But with no way to easily alter the status it causes an error behavior regardless. This brings with it false-positives. |
I too have users who do not consider 4xx as errors of interest. Control over such configuration would be very welcomed. |
Adding my vote to this. The rigid specification around the span status doesn't allow for a variety of use cases in the real world, with the most common request being the ability to override error classification of 4xx status codes. |
@bogdandrutu why did you move this issue into contrib? Changing attribute values is the core functionality of the Collector. Changing status value should be the same, no? |
Please assign this ticket to me. |
Fixed by #5886 |
OpenTelemetry spec currently says the following in the description of
Span.SetStatus
method:From the previous discussions on this topic I assumed that the way for
Operator
to set span status is by using Collector. Unfortunately, Collector does not support setting span status atm. Span Processor supports only changing span name and Attributes Processor, naturally, operate only on attributes and cannot change status.Proposed solution is to expand
Span Processor
and to allow it to change span status.The text was updated successfully, but these errors were encountered: