Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awsfirehosereceiver] Support statistics on top of min/max/sum/count for metrics ingestion #36241

Open
kaiyan-sheng opened this issue Nov 6, 2024 · 1 comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/awsfirehose

Comments

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Nov 6, 2024

Component(s)

receiver/awsfirehose

Is your feature request related to a problem? Please describe.

When ingesting metrics using Firehose, I can see we support min/max/sum/count as statistic methods. But for p99 or p90 or TM(...), it's not supported yet.

 2024-11-05T21:52:57.661Z	info	ResourceMetrics #0
 Resource SchemaURL: 
 Resource attributes:
      -> cloud.provider: Str(aws)
      -> cloud.account.id: Str(123456789012)
      -> cloud.region: Str(us-east-1)
      -> service.namespace: Str(AWS)
      -> service.name: Str(EC2)
      -> aws.cloudwatch.metric_stream_name: Str(cloudwatch-metric-stream-us-east-1)
 ScopeMetrics #0
 ScopeMetrics SchemaURL: 
 InstrumentationScope  
 Metric #0
 Descriptor:
      -> Name: DiskWriteOps
      -> Description: 
      -> Unit: Seconds
      -> DataType: Summary
 SummaryDataPoints #0
 Data point attributes:
      -> service.instance.id: Str(i-123456789012)
 StartTimestamp: 1970-01-01 00:00:00 +0000 UTC
 Timestamp: 2024-11-05 21:52:55.968 +0000 UTC
 Count: 3
 Sum: 20.000000
 QuantileValue #0: Quantile 0.000000, Value 0.000000
 QuantileValue #1: Quantile 1.000000, Value 18.000000
{"kind": "exporter", "data_type": "metrics", "name": "debug"}

Describe the solution you'd like

We should also have quantile values with quantile not only equals to 0 and 1, for example:

 QuantileValue #0: Quantile 0.000000, Value 0.000000
 QuantileValue #1: Quantile 1.000000, Value 18.000000
 QuantileValue #2: Quantile 0.990000, Value 17.560000
 QuantileValue #3: Quantile 0.999000, Value 17.876400

Describe alternatives you've considered

No response

Additional context

Sample metric from CloudWatch:

{"metric_stream_name":"cloudwatch-metric-stream-us-east-1","account_id":"12345678901","region":"us-east-1","namespace":"AWS/EC2","metric_name":"DiskWriteOps","dimensions":{"InstanceId":"i-123456789012"},"timestamp":1730501237425,"value":{"count":3.0,"sum":20.0,"max":18.0,"min":0.0,"p99": 17.56,"p99.9": 17.8764,"TM(25%:75%)": 16.43},"unit":"Seconds"}
@kaiyan-sheng kaiyan-sheng added enhancement New feature or request needs triage New item requiring triage labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/awsfirehose
Projects
None yet
Development

No branches or pull requests

1 participant