Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Token expiry buffer for oauth2clientauthextension #35148

Open
pureklkl opened this issue Sep 11, 2024 · 4 comments
Open

Add Token expiry buffer for oauth2clientauthextension #35148

pureklkl opened this issue Sep 11, 2024 · 4 comments

Comments

@pureklkl
Copy link
Contributor

pureklkl commented Sep 11, 2024

Component(s)

extension/oauth2clientauth

Is your feature request related to a problem? Please describe.

There is a risk that the oauth token expired right after the request being sent and causing a data loss.

Describe the solution you'd like

Add a config for expiry buffer. The change would be like replace the ReuseTokenSource with ReuseTokenSourceWithExpiry and add a config for the expiry. Optional to provide a default expiry buffer
ref:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/oauth2clientauthextension/clientcredentialsconfig.go#L93
https://pkg.go.dev/golang.org/x/oauth2#ReuseTokenSourceWithExpiry

Describe alternatives you've considered

No response

Additional context

No response

@pureklkl pureklkl added enhancement New feature or request needs triage New item requiring triage labels Sep 11, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

Sounds like a valid request to me. Are you open to sending a PR with this change?

@jpkrohling jpkrohling added good first issue Good for newcomers Contribfest and removed needs triage New item requiring triage labels Sep 18, 2024
@pavankrish123
Copy link
Contributor

@jpkrohling I have a pr ready to be submitted, let me push it through, testing free things

Thanks 🙏

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants