Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/splunkhecexporter] Support separate metric index for hec exporter #35039

Closed
spiffyy99 opened this issue Sep 5, 2024 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request exporter/splunkhec

Comments

@spiffyy99
Copy link
Contributor

spiffyy99 commented Sep 5, 2024

Component(s)

exporter/splunkhec

Is your feature request related to a problem? Please describe.

Users of splunkhecexporter may be sending both logs and metrics data at the same time, so the config should provide a separate default metrics index to support this, since metrics and logs indexes support different data.

Describe the solution you'd like

To avoid regressions in existing clients, metrics index can be configured as such:

  • Config introduces an extra optional param MetricsIndex
  • Have an additional config flag UseMetricsIndex. If this is set, metrics exporter will set the default index to be MetricsIndex for metrics data.

Describe alternatives you've considered

No response

Additional context

No response

@spiffyy99 spiffyy99 added enhancement New feature or request needs triage New item requiring triage labels Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Sep 5, 2024

It doesn't look to me like we would need a UseMetricsIndex field. We can just check if MetricsIndex is set.

If MetricsIndex is set, we use it when converting metrics to splunk events. If it is not set, we should default back to the Index config field to preserve the current behavior.

@spiffyy99
Copy link
Contributor Author

It doesn't look to me like we would need a UseMetricsIndex field. We can just check if MetricsIndex is set.

If MetricsIndex is set, we use it when converting metrics to splunk events. If it is not set, we should default back to the Index config field to preserve the current behavior.

good point. that's fine as well.

@crobert-1
Copy link
Member

Removing needs triaged based on response from code owner.

@atoulme
Copy link
Contributor

atoulme commented Oct 25, 2024

@spiffyy99 are you still working on this?

@spiffyy99
Copy link
Contributor Author

No, we decided to go with a different approach. Lets close this out.

@spiffyy99 spiffyy99 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter/splunkhec
Projects
None yet
Development

No branches or pull requests

3 participants