Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/geoip] Align geoIP semantic conventions attributes #34745

Open
rogercoll opened this issue Aug 20, 2024 · 3 comments
Open

[processor/geoip] Align geoIP semantic conventions attributes #34745

rogercoll opened this issue Aug 20, 2024 · 3 comments
Labels
enhancement New feature or request processor/geoip waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized

Comments

@rogercoll
Copy link
Contributor

Component(s)

processor/geoip

Is your feature request related to a problem? Please describe.

A PR is currently being reviewed in the semantic conventions repository, once approved and merged the GeoIP processor should align its added attributes with the semantic convention ones. For example, geo.city_name should be renamed to geo.city.name.

Describe the solution you'd like

Current attributes https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/geoipprocessor/internal/convention/attributes.go should be the same as the to semantic convention ones.

Describe alternatives you've considered

No response

Additional context

No response

@rogercoll rogercoll added enhancement New feature or request needs triage New item requiring triage labels Aug 20, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@rogercoll
Copy link
Contributor Author

Semantic conventions PR merged. Waiting for next semconv release

@mx-psi mx-psi added the waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized label Nov 20, 2024
@rogercoll
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/geoip waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized
Projects
None yet
Development

No branches or pull requests

3 participants