Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to math/rand/v2 #34676

Open
25 tasks
mx-psi opened this issue Aug 14, 2024 · 2 comments · May be fixed by #34685
Open
25 tasks

Migrate to math/rand/v2 #34676

mx-psi opened this issue Aug 14, 2024 · 2 comments · May be fixed by #34685
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2024

Component(s)

No response

Describe the issue you're reporting

Go 1.22 introduced math/rand/v2 which replaces the math/rand stdlib package. We should migrate to it!

Once we have migrated, we can forbid its usage via depguard.

Components using math/rand v1:

  • connector/servicegraphconnector
  • examples/demo
  • exporter/awskinesisexporter
  • exporter/awss3exporter
  • exporter/azuredataexplorerexporter
  • exporter/clickhouseexporter
  • exporter/datasetexporter
  • exporter/loadbalancingexporter
  • exporter/mezmoexporter
  • exporter/otelarrowexporter
  • exporter/rabbitmqexporter
  • internal/aws
  • internal/coreinternal
  • internal/exp
  • internal/otelarrow
  • pkg/batchperresourceattr
  • pkg/sampling
  • pkg/stanza
  • processor/deltatocumulativeprocessor
  • processor/groupbyattrsprocessor
  • processor/probabilisticsamplerprocessor
  • processor/tailsamplingprocessor
  • receiver/awsfirehosereceiver
  • testbed/testbed
  • testbed/tests

(generated with rg math/rand -l -tgo | cut -d'/' -f1-2 | sort | uniq | sed 's/^/- [ ] /')

Counterpart to open-telemetry/opentelemetry-collector/issues/10885.
@mx-psi mx-psi added needs triage New item requiring triage enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:p3 Lowest and removed needs triage New item requiring triage labels Aug 14, 2024
@mx-psi mx-psi mentioned this issue Aug 14, 2024
Closed
2 tasks
@webstradev webstradev linked a pull request Aug 14, 2024 that will close this issue
Open
@github-actions github-actions bot mentioned this issue Aug 20, 2024
Closed
@Kei-Ta
Copy link

Kei-Ta commented Aug 22, 2024

I can pick this up

@mx-psi
Copy link
Member Author

mx-psi commented Aug 22, 2024

@Kei-Ta This is being worked on in the linked PR #34685. Feel free to leave a review there :)

@mx-psi mx-psi linked a pull request Aug 22, 2024 that will close this issue
[chore] Migrate from math/rand to math/rand/v2 #34685
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Migrate from math/rand to math/rand/v2 webstradev/opentelemetry-collector-contrib
2 participants
@mx-psi @Kei-Ta